- h323plus - lists.packetizer.com

Renegotiate media port
by Diego Carvalho Domingos 19 Apr '17

19 Apr '17

Hi all, At some point after the call has been successfully set up, I need to renegotiate the audio (it could be video as well) media port. In my case, I developed a H323-SIP gateway (that does not handle media, only signaling conversion) and the SIP side sent a reinvite with a different audio port, so I need to make the H323 device send media to this new port. How can I accomplish this? (both in terms of the H323 protocol itself and implementing the solution using H323Plus). I appreciate any help, thanks. Diego Carvalho Domingos

3 3

GNU Gatekeeper Survey 2017
by Jan Willamowius 19 Apr '17

19 Apr '17

Dear GnuGk community, could you please give some feedback how you like GnuGk and it can be improved ? I have compiled a quick poll. Please feel free to add any other suggestions you may have. https://www.gnugk.org/survey-2017.html In the past, these surveys have always been a great inspiration. Please keep the feedback coming. Thanks for your time! Jan -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: https://www.gnugk.org Support: https://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584

1 0

GNU Gatekeeper 4.5 released
by Jan Willamowius 16 Mar '17

16 Mar '17

Hi, I'm proud to announce that GNU Gatekeeper 4.5 has been released. The most important change is the implementation of TCP keepalives for H.460.18 (bugfix) and optionally for all kinds of calls (feature). This is really important for NAT traversal. In addition to the keepalives there are a number of bugfixes and a few minor feature additions (see the change notes below). You can download the new version from https://www.gnugk.org/h323download.html Please see the full change log below. Changes from 4.4 to 4.5 ======================= - new feature to send H.225 and H.245 keep-alives for all calls, enable with [RoutedMode] EnableGnuGkTcpKeepAlive=1, set interval with GnuGkTcpKeepAliveInterval=n - BUGFIX(ProxyChannel.cxx) send H.225 and H.245 keep-alives when acting as H.460.18 client - BUGFIX(ProxyChannel.cxx) disable RTP/RTCP port check for IPs in AllowedSignalIPs= when doing port detection - [Proxy] AllowedSignalIPs= can now process a list of networks - add shortcurt 'rl' for status port command 'rotatelog' - new switch [CallTable] SetCalledStationIdToDialedIP=1 - new switch [CallTable] UseDestCallSignalIPAsDialedNumber=1 to place the destSignalIP into the %{DialedNumber} field if no dialed number is available in the ARQ / Setup - BUGFIX(ProxyChannel.cxx) fix crash on invalid sourceCallSignalAddress - add optional parameter for call transfer method to MakeCall status port command - BUGFIX(Toolkit.*) fix bug in IP comparison - BUGFIX(Toolkit.*) the internal networks configured with the [Proxy] InternalNetworks switch were added to the detected internal networks and didn't replace them, now they replace them as documented -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: https://www.gnugk.org Support: https://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584

1 0

packetization mode in TCS.
by Ankur Deep Jaiswal 11 Feb '17

11 Feb '17

Hi can i send packetization mode with TCS for H.264, is there a way to modify TCS before sending it out. help appreciated -- Regards Ankur Deep Jaiswal Ernakulam

3 4

GNU Gatekeeper 4.4 released
by Jan Willamowius 06 Jan '17

06 Jan '17

Hi, GNU Gatekeeper 4.4 was released today. This is mainly a bug fix release with only 2 new features. If you use SSH on your status port you are urged to update as soon as possible and also if you use LUA scripting. Two serious bugs have been fixed for these features where GnuGk can be crashed remotely. A new feature is the RequireOneNet policy that allows you to restrict access to publicly accessible traversal gatekeepers. Now you can easily define that one end of all calls must terminate in one of your own networks and prevent abuse of your resources by 3rd parties. The other new feature is a significant improvement to the MakeCall command on the status port. It is now able to establish video calls and supports virtually all endpoints by using GnuGk's call reroute feature. Changed config switches: - [Proxy] ProxyForNAT now defaults to OFF - [CTI::MakeCall] DisableFastStart has been removed, fastStart is now always disabled You can download the new version from http://www.gnugk.org/h323download.html Please see the full change log below. These know bugs haven't been addressed, yet: - when GnuGk acts as a H.460.18 client (as client in a H.460.18 traversal zone with another gatekeeper or as child gatekeeper), it currently does not send a keep-alive on the Q.931 TCP connection during a call - bandwidth management currently only applies to calls from registered endpoints and ignores unregistered calls completely Changes from 4.3 to 4.4 ======================= - [CTI::MakeCall] TransferMethod can now also be Reroute, DisableFastStart switch removed - BUGFIX(MakeCall.cxx) fix MakeCall bearer capabilities to support video calls - BUGFIX(ProxyChannel.cxx) don't send Notify after call Reroute: Polycom RealPresense starts a flood of Status messages - BUGFIX(GkStatus.cxx) call ssh_init() and ssh_finalize() only on application start and shutdown - BUGFIX(ProxyChannel.cxx) fix IP check for IgnoreSignaledPrivateH239IPs= switch - new accounting/authentication policy RequireOneNet - pass full RRQ message to LuaAuth - BUGFIX(ProxyChannel.cxx) when opening a port from a PortRange fails, try next port regardless of errno - BUGFIX(lua.cxx) add mutex for LUA interpreter, because it is not thread safe - added message type parameter in RouteRequest event (ARQ, Setup, LRQ) - BUGFIX(yasocket.cxx) fix UDP with LARGE_FDSET on Solaris, OpenBSD and NetBSD - BUGFIX(RasTbl.cxx) fix crash on invalid AliasTypeFilter setting - changed default setting: [Proxy] ProxyForNAT now defaults to off, if you want to keep the previous behaviour, please set it explicitely -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: http://www.gnugk.org Support: http://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584

1 0

Recent bug fixes
by Jan Willamowius 04 Jan '17

04 Jan '17

Hi, during the past few months I fixed a few bugs where the remote party can crash a H323Plus application. Much of this came from fuzzy testing sponsored by one of my support clients. There is no official H323Plus release, but I think it would be a good idea for most people to update to the latest CVS version. Regards, Jan -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: https://www.gnugk.org Support: https://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584

1 0

Crash after MakeCall
by Ankur Deep Jaiswal 27 Dec '16

27 Dec '16

Hi , i updated to latest CVS release. and am using ptlib version 2.10.9. i am now getting the following error. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ffff7f13700 (LWP 24402)] 0x00000000004d4a84 in PArray<PASN_Object>::operator[] (this=0x7fffe00463b0, index=0) at /home/test/libs/h323/ptlib/include/ptlib/array.h:1062 1062 PObject * obj = GetAt(index); (gdb) bt #0 0x00000000004d4a84 in PArray<PASN_Object>::operator[] (this=0x7fffe00463b0, index=0) at /home/test/libs/h323/ptlib/include/ptlib/array.h:1062 #1 0x00000000005f8a4a in H245_ArrayOf_VideoCapability::operator[] (this=0x7fffe0046390, i=0) at h245_1.cxx:16846 #2 0x000000000047baa1 in H323CodecExtendedVideoCapability::IsMatch (this=0xc94dc0, subTypePDU=...) at h323caps.cxx:2269 #3 0x0000000000480790 in H323Capabilities::FindCapability (this=0xc93498, mainType=H323Capability::e_Data, subTypePDU=..., translationTable=0x0, tableElements=0) at h323caps.cxx:3902 #4 0x000000000047fbb5 in H323Capabilities::FindCapability (this=0xc93498, cap=...) at h323caps.cxx:3633 #5 0x000000000047f99e in H323Capabilities::FindCapability (this=0xc93498, cap=..., capID=224, pdu=...) at h323caps.cxx:3596 #6 0x000000000047dd40 in H323Capabilities::H323Capabilities (this=0x7ffff7f12bb0, connection=..., pdu=...) at h323caps.cxx:3210 #7 0x00000000004615a3 in H245NegTerminalCapabilitySet::HandleIncoming (this=0xc96a20, pdu=...) at h323neg.cxx:380 #8 0x000000000043c7dc in H323Connection::OnH245Request (this=0xc93370, pdu=...) at h323.cxx:3489 #9 0x000000000043c493 in H323Connection::HandleControlPDU (this=0xc93370, pdu=...) at h323.cxx:3439 #10 0x000000000043c3ad in H323Connection::HandleControlData (this=0xc93370, strm=...) at h323.cxx:3423 #11 0x000000000043bbb0 in H323Connection::HandleReceivedControlPDU (this=0xc93370, readStatus=true, strm=...) at h323.cxx:3344 #12 0x000000000043ba98 in H323Connection::HandleControlChannel (this=0xc93370) at h323.cxx:3326 #13 0x000000000049c093 in H245TransportThread::Main (this=0x7fffec008380) at transports.cxx:221 #14 0x000000000078b34a in PThread::PX_ThreadStart (arg=0x7fffec008380) at ptlib/unix/tlibthrd.cxx:491 #15 0x00007ffff7bc4182 in start_thread (arg=0x7ffff7f13700) at pthread_create.c:312 #16 0x00007ffff6db030d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111 An object of type H245_MasterSlaveDeterminationRelease is getting destructed, i put logs in the constructor and destructor , but the constructor is never called. Regards Ankur Deep Jaiswal

2 1

Transport thread did not terminate
by Ankur Deep Jaiswal 20 Dec '16

20 Dec '16

Hi i some times get hit by a Assertion fail: Transport thread did not terminate, file transports.cxx, line 1204 this always happens after : H323TCP Could not connect to ip:port (local port=0) - Interrupted system call(4) any thoughts -- Regards Ankur Deep Jaiswal

2 2

GNU Gatekeeper 4.3 released
by Jan Willamowius 16 Nov '16

16 Nov '16

Hi, I'm happy to announce the release of GNU Gatekeeper 4.3. This new version contains a number bug fixes and some security fixes. Fuzzy testing surfaced methods to crash GnuGk remotely, causing at least a denial of service. So all users are encouraged to update. The most notable new feature are probably the events for Setup messages on the status port so now you can see all calls. In addition, LuaAuth has been given access to more information about received messages and can end your status port sessions with Ctrl-C now. Important bug fixes are in the H.460 NAT traversal code where sometimes keep-alive intervals could be too long in older versions and a bug where GnuGk might have missed port re-negotiations in some cases. The IgnoreSignaledIPs port detection code also has a few bug fixes to detect cases where it should be turned off automatically because its either not needed because the parties use another form of NAT traversal or non-symmetric ports where the detection algorithm may cause more harm than good. You can download the new version from http://www.gnugk.org/h323download.html Please see the full change log below. Enjoy! Changes from 4.2 to 4.3 ======================= - BUGFIX(ProxyChannel.cxx, gkh235.cxx, gkauth.h) fix crashes found with PROTOS - new authentication policies LuaPasswordAuth, HttpPasswordAuth - BUGFIX(configure.in) fix check for LUA 5.2 or higher - connection to the status port can now also be ended with Ctrl-C - new switch [Routing::DNS] RewriteARQDestination= to preserve URLs in ARQs - disable IgnoreSignaledIPs when one party is not using the same RTP ports for forward and reverse channels in same RTP session - BUGFIX(RasTbl.cxx) don't allow higher TTL for H.460.18 registrations than set by H46018KeepAliveInterval= switch - add variables message, srcInfo and vendor to LuaAuth - print message on status port when Setup is received - BUGFIX(ProxyChannel.cxx) disregard IgnoreSignaledIPs=1 switch when caller supports some form of NAT traversal (to avoid both sides waiting for first RTP packet) - BUGFIX(ProxyChannel.cxx) enable H.245 tunneling for H.460.17 even when Innovaphone forgets the flag - BUGFIX(ProxyChannel.cxx) make sure CRV is 0 for all RAS messages when using H.460.17 even when they relate to a call - BUGFIX(ProxyChannel.cxx) re-do H.460.19 port detection when a new logical channel is opened on the same port - print number of CPU cores and thread configuration on startup - BUGFIX(RasTbl.cxx) fix display of H.460.17 for registrations on status port - BUGFIX(ProxyChannel.cxx) fix dead lock causing reroutes to fail -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: http://www.gnugk.org Support: http://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584

1 0

GNU Gatekeeper 4.2 released
by Jan Willamowius 31 May '16

31 May '16

Hi, I'm happy to announce the release of GNU Gatekeeper 4.2. Version 4.2 is mainly a bug fix release. A bug in proxying H.239 connections through NAT has been fixes as well as a number of possible crashes and a few other small bugs. The main functional change is that GnuGk's old NAT traversal method is now disabled by default. Everybody should use H.460.x. If you want keep using the old NAT traversal method, you can re-enable it with [RoutedMode] EnableGnuGkNATTraversal=1 [Endpoint] EnableGnuGkNATTraversal=1. You can download the new version from http://www.gnugk.org/h323download.html Please see the full change log attached below. Enjoy! -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: http://www.gnugk.org Support: http://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584 Changes from 4.1 to 4.2 ======================= - BUGFIX(ProxyChannel.cxx) fix H.239 forwarding issue in call where only one side uses H.460.19 - BUGFIX(configure.in) make sure LUA test fails for versions below 5.2 - BUGFIX(gkh235.cxx) small fix with password auth - BUGFIX(ProxyChannel.cxx) apply codec filtering also to receiveAndTransmit capabilities - BUGFIX(ProxyChannel.cxx) fix crash in RTP multiplexing - BUGFIX(ProxyChannel.cxx) fix crash when using H.245 tunneling translation - BUGFIX(gk.cxx) fix shutdown on NetBSD 7 - BUGFIX(ProxyChannel.cxx) fix compile on NetBSD 7 - new switch: [RoutedMode] FilterVideoFastUpdatePicture= to reduce the number of update requests from endpoints - disable SSLv3 when using TLS - BUGFIX(ProxyChannel.cxx) fix crash in call cleanup - support ON and OFF event in LuaAcct - BUGFIX(sqlacct.*) implement ON and OFF event as documented - new switches [RoutedMode] EnableGnuGkNATTraversal=1 and [Endpoint] EnableGnuGkNATTraversal=1 to keep GnuGk's old NAT traversal method enabled

1 0

hi
by 陈炳锡-阳阳谷信息科技 26 May '16

26 May '16

hi is it a bug of OpenH323? i have a problem in using openh323, in the OpenH323 transmission channel, i am send more than 65K of the size of the data, it will not be sent out.

1 0

GNU Gatekeeper Survey 2016
by Jan Willamowius 14 Apr '16

14 Apr '16

Dear GnuGk community, I have compiled a quick survey where you can indicate what you like about GnuGk and what is missing. Please feel free to add any other suggestions you may have. http://www.gnugk.org/survey-2016.html In the past, these surveys have always been a great inspiration. Thanks for your time! Jan -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: http://www.gnugk.org Support: http://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584

1 0

h323plus text messaging
by Leonardo Nahra 07 Mar '16

07 Mar '16

Hello, I'm working on a conference project,and we will use the H.323 protocol to establish a connection between monitors, so they can exchange information about configuration options of the video stream they'll receive. So, once a call is established, in addition of exchanging video and audio (that we already have implemented apart), configuration options need to be sent in text format back and forth. Searching through h323plus I couldn't find a way to send text in a call, can you give me some pointers on how to accomplish that? Thanks, Nahra.

4 3

GNU Gatekeeper 4.1 released
by Jan Willamowius 16 Feb '16

16 Feb '16

Hi, I'm happy to announce the availability of GNU Gatekeeper 4.1. This is mainly a bug fix release. If you are using GnuGk as a server in a traversal zone or if you do H.239 presentations with Avaya endpoints, you are strongly encouraged to update. This version also fixes a memory leak that mainly affects long running gatekeepers with a lot of RAS traffic. Some of the bugs were long standing, so if you skipped some previous releases, this is really a good time to update. The main new feature in this release is expanded LUA support. Besides LUA authentication and LUA routing, there is now a LuaAcct module that allows you to run a script on every accounting event of your choice. Please see the updated manual for details. You can download the new version from http://www.gnugk.org/h323download.html Please see the full change log attached to the end of this mail. My support website https://www.willamowius.com also got a face lift. Please check it out as well. Enjoy! -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: http://www.gnugk.org Support: http://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584 Changes from 4.0 to 4.1 ======================= - BUGFIX(ProxyChannel.cxx) fix crash processing Setup - BUGFIX(RasSrv.cxx) update IP/port of traversal neighbor on every SCI, not only on IP changes - new status port command: PrintNeighbors - BUGFIX(ProxyChannel.cxx) fix H.239 inside multiplePayloadStream from Avaya XT5000 with H.460.19 - new accounting module: LuaAcct - LUA: new library "gnugk" to allow access to GnuGk functionality - BUGFIX(configure) set all detected options in gnugkbuildopts.h on Unix - BUGFIX(ProxyChannel.cxx) removing H.235 capabilities might have skipped items - BUGFIX(lua.cxx) initialize all LUA variables for LUA routing - status port configuration (MaxStatusClients, StatusEventBacklog, StatusEventBacklogRegex) now changable at runtime - BUGFIX(GkStatus.cxx) fix StatusEventBacklogRegex for patterns that start at the beginning of the event line - BUGFIX(ProxyChannel.cxx) use RealPresence Group 0-Byte keep-alive for IgnoreSignaledH239PrivateIPs (needs LARGE_FDSET to work) - new switches to set database connect and read timeout (only used by MySQL for now) - new switch to set worker thread idle timeout: [Gatekeeper::Main] WorkerThreadIdleTimeout= - BUGFIX(gk.cxx) better test for gatekeeper shutdown - BUGFIX(Routing.cxx) fix fromIP for ARQ and LRQ RouteRequests - BUGFIX(gkauth.cxx) only call Q.931 checks when activated - BUGFIX(Routing.cxx) fix RouteRequest from unregistered caller who doesn't provide any alias - new switch: [RoutedMode] DisableSettingUDPSourceIP=1

1 0

Issue with H.263 codecs set
by Iurii Gordiienko 01 Feb '16

01 Feb '16

Hi all, I need an advice - how to work with set of H.263 codecs. Basically, I have all H.263 codec types capability implemented: H.263, H.263-1998 and H.263-2000. All these capabilities uses same H245_VideoCapability::e_h263VideoCapability value for GetSubType function. In result my localCapabilities variable has all these 3 capabilities as well. When I receiving remote capabilities the remoteCapabilities variable is loading by H323Capabilities::H323Capabilities(const H323Connection & connection, const H245_TerminalCapabilitySet & pdu) constructor and the function uses code like this (simplified): H323Capability * capability = localCapabilities.FindCapability(pdu.m_capabilityTable[i].m_capability, capabilityNo, pdu); if (capability != NULL) { H323Capability * copy = (H323Capability *)capability->Clone(); copy->SetCapabilityNumber(capabilityNo); if (copy->OnReceivedPDU(pdu.m_capabilityTable[i].m_capability)) table.Append(copy); else delete copy; } The main issue - localCapabilities.FindCapability function returns any first H.263 Capability from it's table, no matter which particular H.263 remote Capability was used, it only checks MainType and SubType... In result if remote side send me, for example, H.263-1998, but I have H.263 and H.263-1998 - I will have H.263 in result... Now I'm trying to override Connection::OnReceivedCapabilitySet(const H245_TerminalCapabilitySet & pdu) function, extract H.263 codecs manually, store all these capabilities and update remoteCapabilities after, but may be exists a proper solution for this case? Thanks -- Iurii Gordiienko

3 4

Bug inH323Capabilities::Remove(H323Capability*)
by Iurii Gordiienko 31 Jan '16

31 Jan '16

Hi, I found a bug - H323Capabilities::Remove function will skip item when doing .RemoveAt operation. In result I have had a crash (in line if (set[outer][middle][inner].GetCapabilityNumber() == capabilityNumber)) for some sets of capabilities. I can't understand why the crash is occurs but in any way... Original code: void H323Capabilities::Remove(H323Capability * capability) { if (capability == NULL) return; PTRACE(3, "H323\tRemoving capability: " << *capability); unsigned capabilityNumber = capability->GetCapabilityNumber(); for (PINDEX outer = 0; outer < set.GetSize(); outer++) { for (PINDEX middle = 0; middle < set[outer].GetSize(); middle++) { for (PINDEX inner = 0; inner < set[outer][middle].GetSize(); inner++) { if (set[outer][middle][inner].GetCapabilityNumber() == capabilityNumber) { set[outer][middle].RemoveAt(inner); break; } } if (set[outer][middle].GetSize() == 0) set[outer].RemoveAt(middle); } if (set[outer].GetSize() == 0) set.RemoveAt(outer); } My fix: void H323Capabilities::Remove(H323Capability * capability) { if (capability == NULL) return; PTRACE(3, "H323\tRemoving capability: " << *capability); unsigned capabilityNumber = capability->GetCapabilityNumber(); for (PINDEX outer = 0; outer < set.GetSize(); ) { for (PINDEX middle = 0; middle < set[outer].GetSize(); ) { for (PINDEX inner = 0; inner < set[outer][middle].GetSize(); inner++) { if (set[outer][middle][inner].GetCapabilityNumber() == capabilityNumber) { set[outer][middle].RemoveAt(inner); break; } } if (set[outer][middle].GetSize()) ++middle; else set[outer].RemoveAt(middle); } if (set[outer].GetSize()) ++outer; else set.RemoveAt(outer); } Thanks -- Iurii Gordiienko

2 1

Double-delete Capability bug
by Iurii Gordiienko 25 Jan '16

25 Jan '16

Hi, I have found something... For H323ExtendedVideoCapability::AddAllCapabilities function we are using H323CodecExtendedVideoCapability::AddCapability function for extCapability->AddCapability(*r). H323CodecExtendedVideoCapability::AddCapability function uses extCapabilities.Add(H323ExtendedVideoFactory::CreateInstance(cap)) function. The function H323ExtendedVideoFactory::CreateInstance(cap) will call "new" if any same "cap" does not is exists for now< for other case it will return the pointer to current actual Capability. But H323CodecExtendedVideoCapability::extCapabilities will delete all items in time of execution extCapabilities.RemoveAll() function from H323CodecExtendedVideoCapability::~H323CodecExtendedVideoCapability(). In result we have "double delete" and undefined behavior (crash for worst case). -------------------------------- void H323ExtendedVideoCapability::AddAllCapabilities( H323Capabilities & basecapabilities, PINDEX descriptorNum,PINDEX simultaneous) { H323ExtendedVideoFactory::KeyList_T extCaps = H323ExtendedVideoFactory::GetKeyList(); if (extCaps.size() > 0) { H323CodecExtendedVideoCapability * capability = new H323CodecExtendedVideoCapability(); H323ExtendedVideoFactory::KeyList_T::const_iterator r; PINDEX num = P_MAX_INDEX; for (r = extCaps.begin(); r != extCaps.end(); ++r) { H323CodecExtendedVideoCapability * extCapability = (H323CodecExtendedVideoCapability *)capability->Clone(); extCapability->AddCapability(*r); num = basecapabilities.SetCapability(descriptorNum, simultaneous,extCapability); simultaneous = num; } simultaneous = P_MAX_INDEX; basecapabilities.SetCapability(descriptorNum, simultaneous,new H323ControlExtendedVideoCapability()); delete capability; } } void H323CodecExtendedVideoCapability::AddCapability(const PString & cap) { extCapabilities.Add(H323ExtendedVideoFactory::CreateInstance(cap)); } ------------------------------------------------- I propose to replace the "void H323CodecExtendedVideoCapability::AddCapability(const PString & cap)" to this one: void H323CodecExtendedVideoCapability::AddCapability(const PString & cap) { extCapabilities.Add(H323ExtendedVideoFactory::CreateInstance(cap)->clone()); } Thanks -- Iurii Gordiienko

3 7

H323EndPoint::ParsePartyName issue
by Iurii Gordiienko 22 Jan '16

22 Jan '16

Hi, I'm working with ForwardCall functional and have found a bug if we have forward URL which contains PORT number. For example, for h323:@192.168.1.1:1726 input string H323EndPoint::ParsePartyName will make address string like ip$192.168.1.1:1726:1726. The fix is trivial (may be I've not covered all cases): // get the various parts of the name PString hostOnly = PString(); PINDEX userPos = remoteParty.Find('@'); if (userPos != P_MAX_INDEX) { if (gatekeeper != NULL) alias = url.AsString(); else { alias = remoteParty.Left(userPos); PINDEX portPos = remoteParty.FindLast(':', portPos + 1); PINDEX len = (portPos != P_MAX_INDEX) ? (portPos - userPos - 1) : P_MAX_INDEX; hostOnly = remoteParty.Mid(userPos+1, len); } } else { alias = url.GetUserName(); hostOnly = url.GetHostName(); } address = hostOnly; Also we have similar issue for input string without '@' character. In this case PTLIB::PURL class wrong parse the string (uses 192.168.1.1:1726:1726 as USER). To fix this issue we need look PTLIB::PURL class futher. Thanks -- Iurii Gordiienko

2 1

Twice H323Connection::Unlock() call issue
by Iurii Gordiienko 22 Jan '16

22 Jan '16

Hi, I have found a bug with twice H323Connection::Unlock() call if we have an connection issue. Take a look: 1.We are running connection.SendSignalSetup function from H225CallThread::Main() and if it returns any reason!=H323Connection::EndedByCallerAbort we will Unlock the connection. void H225CallThread::Main() { PTRACE(3, "H225\tStarted call thread"); if (connection.Lock()) { H323Connection::CallEndReason reason = connection.SendSignalSetup(alias, address); // Special case, if we aborted the call then already will be unlocked if (reason != H323Connection::EndedByCallerAbort) connection.Unlock(); // bla-bla-bla } 2.But we have case when connection.SendSignalSetup returns non H323Connection::EndedByCallerAbort reason but has own unlocked state - for this case PTLIB will unlock the mutex twice with assert (as minimum) message. H323Connection::SendSignalSetup(const PString & alias, const H323TransportAddress & address) { //bla-bla-bla // Release the mutex as can deadlock trying to clear call during connect. Unlock(); PBoolean connectFailed = false; if (!signallingChannel->IsOpen()) { signallingChannel->SetWriteTimeout(100); connectFailed = !signallingChannel->Connect(); } // See if transport connect failed, abort if so. if (connectFailed) { connectionState = NoConnectionActive; switch (signallingChannel->GetErrorNumber()) { case ENETUNREACH : return EndedByUnreachable; case ECONNREFUSED : return EndedByNoEndPoint; case ETIMEDOUT : return EndedByHostOffline; } return EndedByConnectFail; } } Thanks -- Iurii Gordiienko

2 3

H323Connection concurrent access issue
by Iurii Gordiienko 22 Jan '16

22 Jan '16

Hi all, I found an issue with concurrent access during work with H323Connection. Take a look on H46018Transport::HandleH46018SignallingChannelPDU(PThread * thread) Simplest schema of this function running: thread1: H46018Transport::HandleH46018SignallingChannelPDU(PThread * thread) { ... H323Connection * connection = endpoint.CreateConnection(callReference, NULL, this, &pdu); ... connection->AttachSignalChannel(token, this, true); ... connection->HandleSignallingChannel(); ... return connection->HadAnsweredCall(); } The function connection->HandleSignallingChannel() in really working with "this" (H46018Transport object) all time in the while-loop. thread2: H323EndPoint::CleanUpConnections() running. In this thread we are running: 1.connection.CleanUpOnCallEnd() - this function will call CleanUpOnTermination() for signallingChannel (H46018Transport object) which running in connection->HandleSignallingChannel() function. 2.delete current H323Connection (which will delete our signallingChannel object also) The concurrent access issue - in time when we are running connection->HandleSignallingChannel() function from thread1, the H323Connection object can be deleted and signallingChannel will points to dead object - we have a crash in result. Also it is possible to run the connection->HadAnsweredCall() function for dead "connection" object. I have had the crash several times for this situation. Thanks -- Iurii Gordiienko

1 0

H323EndPoint::InternalMakeCall bug
by Iurii Gordiienko 03 Jan '16

03 Jan '16

Hi, I have found an issue with H323EndPoint::InternalMakeCall function for case when it running from H323EndPoint::ForwardConnection function (may be for some others cases too). Take a look: 1.We are trying to connect to some host which uses Gatekeeper. 2.From H323EndPoint::ForwardConnection call H323EndPoint::InternalMakeCall function with some internal token="ip$xxx.xxx.xxx.xxx/port" 3.In the body of H323EndPoint::InternalMakeCall we have the replacement current callToken-connection pair to new one with "ip$xxx.xxx.xxx.xxx/port-replaced-1" string, like connectionsActive.SetAt(adjustedToken, connectionsActive.RemoveAt(newToken)); connectionsToBeCleaned += adjustedToken; 4.But if for some reason our virtual CreateConnection function returns NULL... connection = CreateConnection(lastReference, userData, transport, NULL); if (connection == NULL) { PTRACE(1, "H323\tCreateConnection returned NULL"); connectionsMutex.Signal(); return NULL; } ... we cannot clear current Connection because it has not actual callToken "ip$xxx.xxx.xxx.xxx/port" but H323EndPoint::connectionsActive has "ip$xxx.xxx.xxx.xxx/port-replaced-1" and endpoint.ClearCall(callToken, reason) or something similar will be failed because not able to found the Connection by own callToken. 5.Also we have redundant call connectionsMutex.Signal(). if (connection == NULL) { PTRACE(1, "H323\tCreateConnection returned NULL"); connectionsMutex.Signal(); return NULL; } My proposition - just rename back callToken for H323EndPoint::connectionsActive and remove adjustedToken from H323EndPoint::connectionsToBeCleaned if we have NULL connection. My H323EndPoint::InternalMakeCall function looks like this: H323Connection * H323EndPoint::InternalMakeCall(const PString & trasferFromToken, const PString & callIdentity, unsigned capabilityLevel, const PString & remoteParty, H323Transport * transport, PString & newToken, void * userData, PBoolean supplimentary ) { PTRACE(2, "H323\tMaking call to: " << remoteParty); PString alias; H323TransportAddress address; if (!ParsePartyName(remoteParty, alias, address)) { PTRACE(2, "H323\tCould not parse \"" << remoteParty << '"'); return NULL; } #ifdef H323_H46017 // If H.460.17 use the existing H.460.17 Transport if (transport == NULL && RegisteredWithH46017()) transport = GetH46017Transport(); #endif if (transport == NULL) { // Restriction: the call must be made on the same transport as the one // that the gatekeeper is using. if (gatekeeper != NULL) transport = gatekeeper->GetTransport().GetRemoteAddress().CreateTransport(*this); // assume address is an IP address/hostname else transport = address.CreateTransport(*this); if (transport == NULL) { PTRACE(1, "H323\tInvalid transport in \"" << remoteParty << '"'); return NULL; } } H323Connection * connection; connectionsMutex.Wait(); PString adjustedToken; unsigned lastReference; if (newToken.IsEmpty()) { do { lastReference = Q931::GenerateCallReference(); newToken = BuildConnectionToken(*transport, lastReference, FALSE); } while (connectionsActive.Contains(newToken)); } else { lastReference = newToken.Mid(newToken.Find('/')+1).AsUnsigned(); // Move old connection on token to new value and flag for removal unsigned tieBreaker = 0; do { adjustedToken = newToken + "-replaced"; adjustedToken.sprintf("-%u", ++tieBreaker); } while (connectionsActive.Contains(adjustedToken)); connectionsActive.SetAt(adjustedToken, connectionsActive.RemoveAt(newToken)); connectionsToBeCleaned += adjustedToken; PTRACE(3, "H323\tOverwriting call " << newToken << ", renamed to " << adjustedToken); } connectionsMutex.Signal(); connection = CreateConnection(lastReference, userData, transport, NULL); if (connection == NULL) { PTRACE(1, "H323\tCreateConnection returned NULL"); if (!adjustedToken.IsEmpty()) { connectionsMutex.Wait(); connectionsActive.SetAt(newToken, connectionsActive.RemoveAt(adjustedToken)); connectionsToBeCleaned -= adjustedToken; PTRACE(3, "H323\tOverwriting call " << adjustedToken << ", renamed to " << newToken); connectionsMutex.Signal(); } return NULL; } connection->SetRemotePartyName(remoteParty); if (supplimentary) connection->SetNonCallConnection(); connection->Lock(); connectionsMutex.Wait(); connectionsActive.SetAt(newToken, connection); connectionsMutex.Signal(); connection->AttachSignalChannel(newToken, transport, FALSE); #ifdef H323_H450 if (capabilityLevel == UINT_MAX) connection->HandleTransferCall(trasferFromToken, callIdentity); else { connection->HandleIntrudeCall(trasferFromToken, callIdentity); connection->IntrudeCall(capabilityLevel); } #endif PTRACE(3, "H323\tCreated new connection: " << newToken); #ifdef H323_H46017 if (RegisteredWithH46017()) { H323Connection::CallEndReason reason = connection->SendSignalSetup(alias, address); if (reason != H323Connection::NumCallEndReasons) connection->ClearCall(reason); } else #endif new H225CallThread(*this, *connection, *transport, alias, address); return connection; } Thanks -- Iurii Gordiienko

2 1

H323CodecExtendedVideoCapability::OnSendingPDUstrange behavior
by Iurii Gordiienko 28 Dec '15

28 Dec '15

Hi, Take a look on the H323CodecExtendedVideoCapability::OnSendingPDU function. I have had some issues with Extended capabilities and have fixed the issue only after change the view order - we need to look the .table first and only if it empty - work with extCapabilities. For current implementation we always work the extCapabilities only because it always has GetSize()>0 (otherwise we return FALSE at the beginning of this function). PBoolean H323CodecExtendedVideoCapability::OnSendingPDU(H245_VideoCapability & pdu, CommandType ctype) const { if (extCapabilities.GetSize() == 0) return FALSE; // bla-bla-bla if (extCapabilities.GetSize() > 0) { caps.SetSize(extCapabilities.GetSize()); for (PINDEX i=0; i< extCapabilities.GetSize(); i++) { H245_VideoCapability vidcap; ((H323VideoCapability &)extCapabilities[i]).OnSendingPDU(vidcap,ctype); caps[i] = vidcap; } } else { caps.SetSize(table.GetSize()); for (PINDEX i=0; i< table.GetSize(); i++) { H245_VideoCapability vidcap; ((H323VideoCapability &)table[i]).OnSendingPDU(vidcap,ctype); caps[i] = vidcap; } } return TRUE; } Thanks -- Iurii Gordiienko

1 0

GNU Gatekeeper 4.0 released
by Jan Willamowius 03 Dec '15

03 Dec '15

I am pleased to announce the release of GNU Gatekeeper 4.0. It is now available from http://www.gnugk.org/h323download.html. This release includes source code suitable for Linux, Windows, MacOS X, FreeBSD, NetBSD, OpenBSD and Solaris and executables for Linux. GnuGk 4.0 includes many new features as well as some important bug fixes, but remains fully compatible with your previous configuration files. Whats new ? - rewrite of the H.235 password authentication - much better interoperability and much more secure (it is high time to get ride of MD5 based authentication!) - IP authentication for all RAS and Q.931 messages - important IPv6 updates and fixes - support for TCS0 call transfers ("reroute") that can be initiated from applications - better NAT traversal support for unregistered endpoints - better blocking of spam calls using SQLAuth - per endpoint codec filtering - DisplayIE rewriting - more secure handling of status port passwords (only hash stored) - important fix for ODBC database driver - CalledPartyNumber IE rewriting for better Polycom interoperability - bug fixes Some of the new 4.0 features are discussed in more detail this blog post: http://blog.gnugk.org/2015/11/gnu-gatekeeper-40-features.html The full change log is appended below. Regards, Jan -- Jan Willamowius, Founder of the GNU Gatekeeper Project EMail : jan(a)willamowius.de Website: http://www.gnugk.org Support: http://www.willamowius.com/gnugk-support.html Relaxed Communications GmbH Frahmredder 91 22393 Hamburg Geschäftsführer: Jan Willamowius HRB 125261 (Amtsgericht Hamburg) USt-IdNr: DE286003584 Changes from 3.9 to 4.0 ======================= - [...PasswordAuth] CheckID switch is now deprecated, use [H235] CheckSendersID instead - provide vendor informations from ARQ or Setup as %{Vendor} in SQLAuth CallQuery - prepend timestamp to events in status port backlog - BUGFIX(Routing.cxx) remove newlines from vendor string before sending out RouteRequest to virtual queue - BUGFIX(gksql_odbc.cxx) fix DSN initialization when having multiple DSNs at the same time - new switch: [RoutedMode] UpdateCalledPartyToH225Destination=1 to always rewrite the CalledPartyNumberIE in Setup to the first E.164 of the H.225 destinationAddress - BUGFIX(ProxyChannel.cxx) fix crash on shutdown - new settings for [RoutedMode] ScreenDisplayIE=: 'Calling', 'Called', 'CallingCalled' to set the DisplayIE to the (rewritten) caller ID - new switch: [RoutedMode] AppendToDisplayIE= to add a string to the DisplayIE when ScreenDisplayIE= is on - changed default: H.460.18 keep-alive in traversal zone between neighbors now defaults to 19 sec (was 29) - new switch: [RoutedMode] H46018KeepAliveInterval= - BUGFIX(ProxyChannel.cxx) better port detection for H.239 when IgnoreSignaledPrivateH239IPs=1 - BUGFIX(gkacct.cxx) %{caller-port} and %{called-port} now default to "0" instead of the empty string when not available (eg. in direct mode) to avoid SQL errors when they are stored in a numeric column - BUGFIX(RasSrv.cxx) fix additive registration with parent gatekeeper - BUGFIX(ProxyChannel.cxx) fix IPv6 dual-stack proxy on Linux and Windows - dump file descriptor usage on USR2 signal (Linux only) - new switch [RoutedMode] DisableFastStart=1 - support for H.235.1, incl. setting and checking tokens in all RAS and Q.931 messages - extend SimplePasswordAuth and FileIPAuth to all RAS and all Q.931 messages - store only PBKDF2 hash for [GkStatus::Auth] password in config, not a recoverable password - BUGFIX(ProxyChannel.cxx) fix crash when receiving message without UUIE - new switch [EP::] DisabledCodecs= - much improved TCS0 3rd-party call transfer using 'Reroute' command on status port - BUGFIX(Routing.cxx) add field for destination alias in ARQ if missing and a dynamic routing policy sets it - BUGFIX(ProxyChannel.cxx) fix crash in H.235 Media for endpoints with more than 64 capability entries in TCS - new switch [Proxy] AllowSignaledIPs= to skip to skip auto-detect for network when IgnoreSignaledIPs=1

1 0

OpenExtendedChannel SessionID
by Ankur Deep Jaiswal 16 Sep '15

16 Sep '15

Hi, some devices reject the OLC of extended channel if the sessionid is 0(default), with (OLC reject) invalidsessionid. This is defined in file h323caps.cxx, OnH239GenericMessageResponse as defaultSession=0, after changing the value to 3. the OLC is accepted. In the attached mail-list discussion it is mentioned that sessionid should not be 0 ( http://lists.packetizer.com/pipermail/h323plus/2009-December/002105.html). h323plus displays forgiving nature in this case. it happily accepts a sessionid of 0 in an extended channel. please advise on this behaviour. -- Ankur Deep Jaiswal

1 0

H323Transport GetLocalAddress bug using PTLIB>=2.11
by Jose Uceda 23 Jul '15

23 Jul '15

We discovered this bug trying to register an endpoint (ip 62.22.27.131) to a gatekeeper (ip 62.22.20.229), using H323Plus v1.26.5 w ptlib 2.12.8. As you can see in the trace log: ------------------------ 0:00.010 Yate H323G...f3d7464700 transports.cxx(2363) RAS Gatekeeper discovery on interface: 62.22.27.131:59483 0:00.021 Yate H323G...f3d7464700 h323pdu.cxx(79) Trans Sending PDU [ip$62.22.27.131:59483/ip$62.22.20.229:1719] : gatekeeperRequest { requestSeqNum = 36153 protocolIdentifier = 0.0.8.2250.0.7 rasAddress = ipAddress { ip = 4 octets { 3e 16 1b 83 >... } port = 59483 } ^^^--- We see our RAS Address is set correctly (3e 16 1b 83 = 62.22.27.131) and port 59483 ... rest of the PDU trace has been trimmed ... } 0:00.076 Yate H323G...f3d7464700 h323pdu.cxx(79) H225RAS Receiving PDU [ip$62.22.20.229:54287/ip$62.22.20.229:1719] : gatekeeperConfirm { requestSeqNum = 36153 protocolIdentifier = 0.0.8.2250.0.7 gatekeeperIdentifier = 9 characters { 0047 004b 0040 0070 0070 0063 0069 0067 GK@ppcig 006b k } rasAddress = ipAddress { ip = 4 octets { 3e 16 14 e5 >... } port = 1719 } } Raw PDU: size=25 pos=25.0 { 000 04 80 8d 38 06 00 08 91 4a 00 07 10 00 47 00 4b 8 J G K 00 40 00 70 00 70 00 63 00 69 00 67 00 6b 00 3e @ p p c i g k > 16 14 e5 06 b7 } 0:00.076 Yate H323G...f3d7464700 gkclient.cxx(288) RAS Gatekeeper discovery found ip$62.22.20.229:1719 0:00.076 Yate H323G...f3d7464700 transports.cxx(2461) RAS Gatekeeper discovered at: 62.22.20.229:1719 (if=62.22.27.131:59483) ^^^^---- this transport still has the correct interface / local ip 0:00.076 Yate H323G...f3d7464700 osutil.cxx(189) PTLib File handle high water mark set: 26 Thread unblock pipe 0:00.077 Yate H323G...f3d7464700 tlibthrd.cxx(305) PTLib Created thread 0x7ff3b4008420 Transactor:%x 0:00.077 PTLib Hous...f3d7568700 osutils.cxx(2158) PTLib Cleaning 1 AutoDelete threads 0:00.077 Transactor:d31ab700 tlibthrd.cxx(354) PTLib Started thread 0x7ff3b4008420 (5287) "Transactor:d31ab700" 0:00.077 Transactor:d31ab700 h323trans.cxx(266) Trans Starting listener thread on Transport[remote=ip$62.22.20.229:1719 if=ip$62.22.20.229:54287] ^^^--- See that this new transport has a wrong "if=" (with remote GK address not our local address) 0:00.077 Yate H323G...f3d7464700 transports.cxx(749) TCP Appending H.225 transport ip$62.22.27.131:2720 using associated transport Transport[remote=ip$62.22.20.229:1719 if=ip$62.22.20.229:54287] 0:00.077 Transactor:d31ab700 h323trans.cxx(274) Trans Reading PDU 0:00.077 Transactor:d31ab700 tlibthrd.cxx(1012) PTLib PThread::PXBlockOnIO(22,0) 0:00.077 Yate H323G...f3d7464700 h323trans.cxx(435) Trans Making request: registrationRequest 0:00.077 Yate H323G...f3d7464700 h323pdu.cxx(79) Trans Sending PDU [ip$62.22.20.229:54287/ip$62.22.20.229:1719] : registrationRequest { requestSeqNum = 36154 protocolIdentifier = 0.0.8.2250.0.7 discoveryComplete = true callSignalAddress = 1 entries { [0]=ipAddress { ip = 4 octets { 3e 16 1b 83 >... } port = 2720 } ^^^---- callSignalAddress is our endpoint IP address (62.22.27.131). Ok } rasAddress = 1 entries { [0]=ipAddress { ip = 4 octets { 3e 16 14 e5 >... } port = 59483 } } ^^^--- rasAddress has been set incorrectly to the remote gatekeeper address (62.22.20.229) although the port is OK (it's the same used in the previous GRQ pdu) } ------------------- By looking at the source code: In transports.cxx, function H323TransportUDP::ReadPDU: PBoolean H323TransportUDP::ReadPDU(PBYTEArray & pdu) #if PTLIB_VER >= 2110 if (canGetInterface) { WORD notused; // TODO: verify that this actually does the same as the pre 2.11.x version socket->GetLastReceiveAddress(lastReceivedInterface, notused); } #else if (canGetInterface) lastReceivedInterface = socket->GetLastReceiveToAddress(); #endif Since the PTLIB's version we are using is 2.12.8, the compiled code is as follows: WORD notused; // TODO: verify that this actually does the same as the pre 2.11.x version socket->GetLastReceiveAddress(lastReceivedInterface, notused); Be noticed the comment and that the name of the called function is not the same as the pre 2.11.x code: GetLastReceiveAddress() vs GetLastReceiveToAddress() GetLastReceiveToAddress() returned local ip address but this function has been removed from PTLib and the existing function (the one is used) GetLastReceiveAddress returns the address of the *sender* in the last connection. Due to use GetLastReceiveAddress, now lastReceivedInterface has the remote ip (62.22.20.229). And lastReceivedInterface is used in the function H323TransportUDP::GetLocalAddress(): H323TransportAddress H323TransportUDP::GetLocalAddress() const { if (canGetInterface && !lastReceivedInterface.IsLoopback()) return H323TransportAddress(lastReceivedInterface, interfacePort); ..... returning lastReceivedInterface (62.22.20.229) as our local address incorrectly. The GetLocalAddress function is used in many places so this can cause many problems as the one we have spotted here.

3 2