[h323plus] Size constraints for H225_ArrayOf_EnumeratedParameter

[Jan Willamowius]

Hi Dennis,

PTLib has a default limit of 128 items on enumerations, arrays etc.
I have seen a similar limitation being hit with the number of aliases
on registrations.

Unfortunately we can't just insert that line into h225_2.cxx. That file
is generated from the ASN.1 definition provided by the ITU (using
asnparse). The change will be overwritten on the next import.

There probably won'be many new versions coming, but can't you find a
another place how we can set this ?

Regards,
Jan

-- 
Jan Willamowius, Founder of the GNU Gatekeeper Project
EMail : jan at willamowius.de
H.323 Support: https://www.willamowius.com/

Relaxed Communications GmbH
Frahmredder 91
22393 Hamburg
Geschäftsführer: Jan Willamowius
HRB 125261 (Amtsgericht Hamburg)
USt-IdNr: DE286003584


Denis Kochmashev wrote:
> Hello!
> 
>  
> 
> I have encountered something which looks like a bug. When I add parameters
> to my custom H460_Feature via 
> 
>         H460_FeatureTable table;
> 
> :
> 
>         table.AddParameter(id, content);
> 
> :
> 
>         SetCurrentTable(table);
> 
>  
> 
> H323Plus produces malformed packet with incorrectly encoded size of
> H225_ArrayOf_EnumeratedParameter. I've found that size constraints for
> H225_ArrayOf_EnumeratedParameter are not beeing set, however, according to
> spec, they had to be set. So, if my conclusion is right, I propose a small
> patch like the following:
> 
>  
> 
> --- h225_2.cxx.orig     2013-07-23 00:26:59.000000000 +0600
> 
> +++ h225_2.cxx  2017-10-23 11:00:27.000000000 +0500
> 
> @@ -19,6 +19,7 @@
> 
> H225_ArrayOf_EnumeratedParameter::H225_ArrayOf_EnumeratedParameter(unsigned
> tag, PASN_Object::TagClass tagClass)
> 
>    : PASN_Array(tag, tagClass)
> 
> {
> 
> +  SetConstraintBounds(PASN_Object::FixedConstraint, 1, 512);
> 
> }
> 
>  
> 
> Regards,
> 
> Denis
>