[h323plus] Size constraints for H225_ArrayOf_EnumeratedParameter

[Denis Kochmashev]

Hello!

 

I have encountered something which looks like a bug. When I add parameters
to my custom H460_Feature via 

        H460_FeatureTable table;

:

        table.AddParameter(id, content);

:

        SetCurrentTable(table);

 

H323Plus produces malformed packet with incorrectly encoded size of
H225_ArrayOf_EnumeratedParameter. I've found that size constraints for
H225_ArrayOf_EnumeratedParameter are not beeing set, however, according to
spec, they had to be set. So, if my conclusion is right, I propose a small
patch like the following:

 

--- h225_2.cxx.orig     2013-07-23 00:26:59.000000000 +0600

+++ h225_2.cxx  2017-10-23 11:00:27.000000000 +0500

@@ -19,6 +19,7 @@

H225_ArrayOf_EnumeratedParameter::H225_ArrayOf_EnumeratedParameter(unsigned
tag, PASN_Object::TagClass tagClass)

   : PASN_Array(tag, tagClass)

{

+  SetConstraintBounds(PASN_Object::FixedConstraint, 1, 512);

}

 

Regards,

Denis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.packetizer.com/pipermail/h323plus/attachments/20171023/73b8f190/attachment.html>