[h323plus] Compilation issue

[Diego Carvalho]

Hi All,

I'd like to report what I think is an issue.

If you compile H323Plus after running configure without any option you will
get this warning:

[CC] /home/diego/Edifire/Quartz/3rdParty/h323plus/src/h460/h460_std18.cxx
/home/diego/Edifire/Quartz/3rdParty/h323plus/src/h460/h460_std18.cxx:54:2:
warning: #warning ("H.460.18/.19 Enabled. See Tandberg Patent License.
http://www.tandberg.com/collateral/tandberg-ITU-license.pdf") [-Wcpp]
[CC] /home/diego/Edifire/Quartz/3rdParty/h323plus/src/h460/h46018_h225.cxx
[CC] /home/diego/Edifire/Quartz/3rdParty/h323plus/src/h460/h460_std23.cxx
/home/diego/Edifire/Quartz/3rdParty/h323plus/src/h460/h460_std23.cxx:59:2:
warning: #warning ("H.460.23/.24 Enabled. Contact
consulting at h323plus.orgfor licensing terms.") [-Wcpp]

Since I don't use H.460, I tried to disable the series that are generating
the issues, that is .18/.19 and .23/.24 by running "./configure
--disable-h46018 --disable-h46023" but I got the following error:

h323.cxx: In member function ‘void H323Connection::DisableNATSupport()’:
h323.cxx:2642:30: error: ‘IsH46019Multiplexed’ was not declared in this
scope

If I disable the entire H.460 support by running "./configure
--disable-h460" it compiles successfully and without the warnings I wanted
to omit. So that's fine for me but I think there is a bug in the code that
is causing this compilation issue. In h323.cxx, around line 2642, the code
is:

void H323Connection::DisableNATSupport() {
#if H323_H460
    if (!IsH46019Multiplexed())
#endif
        NATsupport = false;

    remoteIsNAT = false;
}

I think it should be #if H323_H46018 (or both H323_H46018 and
H323_H46019M). This is just a guess since I'm not an expert in the H323Plus
code. And sorry if this issue was caused by some mistake in my
configuration. Best regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.packetizer.com/pipermail/h323plus/attachments/20131230/299d9ef3/attachment-0001.html>