[h323plus] Error in PTLib version check macro

[Denis Kochmashev "Enforta"]

Simon,

 

I was wrong but an error still exists. And it has another solution. I hope
this time it is the right one J

 

Let's look at PTLIB_VER macro definition.

 

#if PTLIB_MAJOR == 2 && PTLIB_MINOR < 10

   #define PTLIB_VER ( PTLIB_MAJOR*100 + PTLIB_MINOR*10 + PTLIB_BUILD )

#else

   #define PTLIB_VER ( PTLIB_MAJOR*1000 + PTLIB_MINOR*10 + PTLIB_BUILD )

#endif

 

Current PTLib SVN 2.10-branch version is 2.10.10.

 

For 2.10.10 PTLIB_VER will be 2*1000 + 10*10 + 10 = 2110

For 2.11.0 PTLIB_VER will be 2*1000 + 11*10 + 0 = 2110

 

There are a lot of conditions like #if PTLIB_VER >= 2110 which imply PTLIb
2.11+ interface calls.

 

So if I try to build H323Plus with PTLib 2.10.10 I get the following result:

[CC] h323.cxx

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/h323plus/include/h460/h4
6018_h225.h:382: error: 'NatTypes' does not name a type

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/h323plus/include/h460/h4
6018_h225.h:383: error: 'NatTypes' does not name a type

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/h323plus/include/h460/h4
6018_h225.h:390: error: 'NatTypes' does not name a type

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/ptlib/include/ptlib/vide
oio.h:1168: warning: 'PPlugin_PVideoInputDevice_FakeVideo_loader' defined
but not used

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/ptlib/include/ptlib/vide
oio.h:1175: warning: 'PPlugin_PVideoInputDevice_FFMPEG_loader' defined but
not used

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/ptlib/include/ptlib/vide
oio.h:1179: warning: 'PPlugin_PVideoInputDevice_YUVFile_loader' defined but
not used

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/h323plus/include/h460/h4
6018_h225.h:430: warning: 'PPlugin_PNatMethod_H46019_loader' defined but not
used

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/ptlib/include/ptlib/plug
inmgr.h:175: warning: 'PFactoryLoader::PluginLoaderStartup_loader' defined
but not used

/usr/local/ims/build/asterisk/ast-h323/branches/1.8/ptlib/include/ptclib/pna
t.h:362: warning: 'PFactoryLoader::PSTUNClient_loader' defined but not used

gmake[2]: ***
[/usr/local/ims/build/asterisk/ast-h323/branches/1.8/h323plus/lib/obj_d/h323
.o] Error 1

gmake[2]: Leaving directory
`/usr/local/ims/build/asterisk/ast-h323/branches/1.8/h323plus-cvs_latest/src
'

gmake[1]: *** [debug] Error 2

gmake[1]: Leaving directory
`/usr/local/ims/build/asterisk/ast-h323/branches/1.8/h323plus-cvs_latest/src
'

gmake: *** [debug] Error 2

 

Changing

 

#if PTLIB_MAJOR == 2 && PTLIB_MINOR < 10

 

to

 

#if PTLIB_MAJOR == 2 && PTLIB_MINOR <= 10

 

in include/openh323buildopts.h.in solves the problem with PTLib 2.10.10.

 

 

Denis

 

From: Simon Horne [mailto:s.horne at spranto.com] 
Sent: Tuesday, December 11, 2012 12:38 AM
To: 'Denis Kochmashev "Enforta"'
Cc: h323plus at lists.packetizer.com
Subject: RE: [h323plus] Error in PTLib version check macro

 

Denis

 

The current PTLIB SVN is 2.13.0 or PTLIB_VER 2130  

 

I think h323plus CVS is now patched appropriately to compile successfully
with PTLIB SVN

Let me know if I have missed something.

 

Simon

 

From: h323plus-bounces at lists.packetizer.com
[mailto:h323plus-bounces at lists.packetizer.com] On Behalf Of Denis Kochmashev
"Enforta"
Sent: 10 December 2012 20:45
To: h323plus at lists.packetizer.com
Subject: [h323plus] Error in PTLib version check macro

 

Hello!

 

Perhaps you already know that there is a small error in PTLib version check
macro in latest CVS version of H323Plus. I think that PTLIB_VER should be
compared to 21100 instead of 2110.

 

Regards,

Denis

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.packetizer.com/pipermail/h323plus/attachments/20121211/57c3f838/attachment.htm>