Craig
I think we all are in agreement.
Inline...
-----Original Message----- From: Craig Southeren [mailto:craigs@postincrement.com] Sent: Tuesday, November 20, 2007 7:19 PM To: Simon Horne; opalvoip-devel@lists.sourceforge.net Cc: Jan Willamowius; Robert Jongbloed; h323plus@lists.packetizer.com Subject: Re: [h323plus] Introducing PBoolean - API change alert!!!
Simon Horne wrote:
Jan
A quick check of GnuGk head shows 53 BOOL. Most of them are virtual of pwlib/openH323 code. Not too much trouble. h323plus shows 4,650 BOOL :)
I am certainly supportive of moving everything over to PBoolean
as long as.
- We have a compile directive (which I think was mentioned)
that subclasses
PBoolean of BOOL instead of bool and that directive is
available to derived
applications so they can detect which PBoolean is actually being used independent of the ptlib version so legacy code can still run
OK with newer
versions of ptlib and as Jan mentioned we can add a typedef
PBoolean BOOL
for legacy compilations of GnuGk.
Just so I understand, you want the following:
- A configure option to use a backwards-compatible version ofPBoolean, and to ensure the symbol BOOL is defined as before. This is already present
Great!
- A runtime symbol that indicates whether the new PBoolean type isbeing used
If this is the case, then I see no problem.
This is there so even if the existing code is not updated a simple compilation chech can advise the developer to use the backwards compatible compilation.
- The ASN.1 compiler is changed to PBoolean (I don't know
whether that has
been done yet?). There certainly is a few ASN.1 files that need
reparsing.
It's simple find and replace. I've just checked in a new version of ASNParser that uses and outputs PBoolean.
Great! Should we reparse or just globally replace the asnparser generated .h/.cxx files? I suppose it doesn't matter...
- A clear ptlib version this will become effective of so we
can all sync
together to make a smooth transition. Next monday is a little
short notice
:)
Understood
Set a ptlib version number for the transition and a few weeks to get things in order and lets do it. Jan and I can work together to ensure things go smoothly.
Simon No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.5.503 / Virus Database: 269.16.1/1140 - Release Date: 2007/11/19 7:05 PM