Hello all,<div><br></div><div> I&#39;ve been playing with h.264-x264 plugin for a while and since I had no problems between h323plus vs h323plus nor OpenPhone 3.8.3 application I do have problems with </div><div><br></div>
<div>video codec h.264 for h323 from recent h323 plus  (e.g. version 1.22.0, 01/11/2011)</div><div>and </div><div>application based on recent opal (rev. 25192)</div><div><br></div><div>I say &quot;possible&quot; because - as was said from few recent mails on mailing lists, opal and h323+ have similar root but they don&#39;t share plugins (necessarily). Nevertheless, when I tried to make a connection from OPAL application to h323+ based application, where both used h264-x264 plugin from h323plus video codecs (v. 1.22.0), my opal application crashed. </div>
<div>I traced down the problem and fixed the lines in h264-x264.cxx and now it works for me.</div><div><br></div><div><br></div><div><br></div><div>Problem was following :</div><div><br></div><div>during the codec options set stage a method of OpalPluginMediaFormatInternal class is called. This one (opalpluginmgr.cxx)</div>
<div><br></div><div>bool OpalPluginMediaFormatInternal::AdjustOptions(OpalMediaFormatInternal &amp; fmt, OpalPluginControl &amp; control) const</div><div><br></div><div>call was made from void H323Capabilities::BuildPDU(const H323Connection &amp; connection,  H245_TerminalCapabilitySet &amp; pdu) const</div>
<div>line n.2706 (capability.GetWritableMediaFormat().ToCustomisedOptions();) in h323caps.cxx</div><div><br></div><div>in method AdjustOptions there are 2 variables set inside :</div><div><br></div><div><div>    char ** input = fmt.GetOptions().ToCharArray(false);</div>
<div>    char ** output = input;</div></div><div><br></div><div>and yes there are set *correctly*</div><div><br></div><div>they are immediately followed by this line (in my case line n. 477 in opalpluginmgr.cxx)</div><div>
<br></div><div>    bool ok = control.Call(&amp;output, sizeof(output)) != 0;</div><div><br></div><div>which calls (opalpluginmgr.h)</div><div><br></div><div>    int  OpalPluginControl::Call(void * parm, unsigned   parmLen, void * context = NULL) const</div>
<div><br></div><div>and that one calls </div><div><br></div><div>    int OpalPluginControl::Call(void * parm, unsigned * parmLen, void * context = NULL) const</div><div><br></div><div>(these 2 methods are not same, difference is in the second parameter, one is not a pointer other is) and this second Call(..) calls to_customised_options from h264_x264.cxx</div>
<div><br></div><div><div>    static int to_customised_options(const struct PluginCodec_Definition * codec, void * _context, const char *, void * parm, unsigned * parmLen)</div><div><br></div></div><div>and there is a line (in my case 837)</div>
<div><br></div><div>    const char ** option = (const char **)parm;</div><div><br></div><div>and here is the problem. if you look at the chain :</div><div><br></div><div>    AdjustOptions &gt; Call &gt; the &quot;other&quot; Call &gt; to_customised_options</div>
<div><br></div><div>then you see that the output variable is transfered as :</div><div><br></div><div>   AdjustOptions               &amp;output    char***</div><div>   Call                              parm        void *</div>
<div>   Call                              parm        void *</div><div>   to_customised_options  parm        void*</div><div><br></div><div>so in the end, parm is char *** and not char ** and this caused the crash</div><div>
<br></div><div><br></div><div><br></div><div> How I fixed it </div><div><br></div><div>changed &quot;to_custoimized_options&quot;, file h323plus/plugins/video/H.264/h264-x264.cxx, line number 837</div><div>   const char ** option = (const char **)parm;</div>
<div>to</div><div>   const char ** option = *((const char ***)parm);</div><div><br></div><div>and also (same function, same file, line 858)</div><div>    char ** options = (char **)parm;</div><div>to</div><div>    char ** options = *((char ***)parm);</div>
<div><br></div><div>recompiled h264 plugin and it works.</div><div><br></div><div><br></div><div><br></div><div>Best regards,</div><div><br></div><div> Vladimir Fekete</div><div><br></div><div>P.S.  I don&#39;t want to call it a bug because I&#39;m not sure whether it&#39;s valid to mix h323plus codecs with opal (eg. separately they may work ok).</div>