On 8/5/2010 10:49 AM, Jan Willamowius wrote:
Now you are down to 2 warnings from cppcheck for H323Plus. Your next step now is to manually check those 2 instances if you think anything needs to be done.
To me they look ok. What is your take ?
Yes we are in better position now :), the only thing left is ptlib errors.
Regards, Mayank Jain
ptlib. Regards, Jan
Mayank Jain wrote:
On 8/5/2010 10:12 AM, Jan Willamowius wrote:
Hi Mayank,
H323Plus is a library that provides applications with functions to use. In contrast to an application, the fact that some functions aren't used internally, is no indication that anything is wrong or that they should be removed.
You are right Jan. I should not use the --unused-function option. Attached are the updated files.
Regards, Mayank Jain
Regards, Jan
Mayank Jain wrote:
Attached are some more issues that can be addressed with h323 and ptlib.
Tool used is cppcheck
cppcheck --all -f -j 13 -q -s --unused-functionsRegards, Mayank Jain