What version of PTLIB are you using?

I checked in a fix to the CVS to call SetInterval() instead of casting.

Simon

From: h323plus-bounces@lists.packetizer.com [mailto:h323plus-bounces@lists.packetizer.com] On Behalf Of Ankur Deep Jaiswal
Sent: 05 May 2014 20:08
To: h323plus@lists.packetizer.com
Subject: Re: [h323plus] Null pointer reference

Hi,

I was able to solve that issue by type casting 'roundTripDelayRate' to int64_t at h323.cxx:6764 . PInt64 supports type casting.

i have a serious doubt about the code though ,

in this code starting at line 6758

void H323Connection::MonitorCallStatus()

{

if (!Lock())

return;

if (roundTripDelayTimer > 0 && !roundTripDelayTimer.IsRunning()) {

roundTripDelayTimer = roundTripDelayRate;

StartRoundTripDelay();

}

the 'roundTripDelayTimer' is never initialized any where in the code. it is also a protected member of the class,as such the condition in the if block may never be entered.

so going by previous definiton at v1.26.3

where the code is

void H323Connection::MonitorCallStatus()

{

if (!Lock())

return;

if (endpoint.GetRoundTripDelayRate() > 0 && !roundTripDelayTimer.IsRunning()) {

roundTripDelayTimer = endpoint.GetRoundTripDelayRate();

StartRoundTripDelay();

}

shouldn't the code be like this .

void H323Connection::MonitorCallStatus()

{

if (!Lock())

return;

if (roundTripDelayRate > 0 && !roundTripDelayTimer.IsRunning()) {

roundTripDelayTimer = ((int64_t)roundTripDelayRate);

StartRoundTripDelay();

}

On Mon, May 5, 2014 at 2:42 PM, Ankur Deep Jaiswal <ankur@techgentsia.com> wrote:

Hi,

This is the complete compile trace . i dont get this with v1.26.3

[CC] h323.cxx

h323.cxx: In member function ‘void H323Connection::MonitorCallStatus()’:

h323.cxx:6764:25: error: ambiguous overload for ‘operator=’ (operand types are ‘PTimer’ and ‘PInt64 {aka long long int}’)

roundTripDelayTimer = roundTripDelayRate;

h323.cxx:6764:25: note: candidates are:

In file included from /home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib.h:66:0,

from h323.cxx:30:

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:228:14: note: PTimer& PTimer::operator=(const PTimer&)

PTimer & operator=(

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:48:11: note: PTimer& PTimer::operator=(int16_t)

cls & operator=( int16_t rhs) { this->SetInterval(rhs); return *this; } \

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:232:5: note: in expansion of macro ‘PTIMER_OPERATORS’

PTIMER_OPERATORS(PTimer);

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:49:11: note: PTimer& PTimer::operator=(uint16_t)

cls & operator=(uint16_t rhs) { this->SetInterval(rhs); return *this; } \

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:232:5: note: in expansion of macro ‘PTIMER_OPERATORS’

PTIMER_OPERATORS(PTimer);

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:50:11: note: PTimer& PTimer::operator=(int32_t)

cls & operator=( int32_t rhs) { this->SetInterval(rhs); return *this; } \

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:232:5: note: in expansion of macro ‘PTIMER_OPERATORS’

PTIMER_OPERATORS(PTimer);

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:51:11: note: PTimer& PTimer::operator=(uint32_t)

cls & operator=(uint32_t rhs) { this->SetInterval(rhs); return *this; } \

/home/ankur/h323plustest1.26.3/ptlibbuild/include/ptlib/timer.h:232:5: note: in expansion of macro ‘PTIMER_OPERATORS’

PTIMER_OPERATORS(PTimer);

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:52:11: note: PTimer& PTimer::operator=(int64_t)

cls & operator=( int64_t rhs) { this->SetInterval(rhs); return *this; } \

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:232:5: note: in expansion of macro ‘PTIMER_OPERATORS’

PTIMER_OPERATORS(PTimer);

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:53:11: note: PTimer& PTimer::operator=(uint64_t)

cls & operator=(uint64_t rhs) { this->SetInterval(rhs); return *this; } \

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:232:5: note: in expansion of macro ‘PTIMER_OPERATORS’

PTIMER_OPERATORS(PTimer);

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:54:11: note: PTimer& PTimer::operator=(const PTimeInterval&)

cls & operator=(const PTimeInterval & rhs) { this->SetInterval(rhs.GetMilliSeconds()); return *this; } \

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/timer.h:232:5: note: in expansion of macro ‘PTIMER_OPERATORS’

PTIMER_OPERATORS(PTimer);

In file included from /home/ankur/h323plustest1.26.x/ptlibbuild/include/ptclib/pnat.h:43:0,

from /home/ankur/h323plustest1.26.x/h323plus/include/ptlib_extras.h:51,

from /home/ankur/h323plustest1.26.x/h323plus/include/h235auth.h:51,

from /home/ankur/h323plustest1.26.x/h323plus/include/h323con.h:46,

from h323.cxx:37:

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptclib/pnat.h: At global scope:

/home/ankur/h323plustest1.26.x/ptlibbuild/include/ptlib/plugin.h:199:13: warning: ‘PPlugin_PNatMethod_STUN_loader’ defined but not used [-Wunused-variable]