Guys The intent was always to have the switch < 10 and <= 10 change was only recently added. I'm not exactly sure why . I have reverted it back and added fix for that and PTLIB BUILD numbers 10 or greater. Let me know if something breaks. Simon -----Original Message----- From: h323plus-bounces@lists.packetizer.com [mailto:h323plus-bounces@lists.packetizer.com] On Behalf Of Jan Willamowius Sent: 11 April 2013 01:47 To: h323plus@lists.packetizer.com Subject: Re: [h323plus] PTLIB_VER versioning I don't think thats intended. Do you want to propose a change that is both compatible with existing source code and doesn't require too wide spread changes ? Regards, Jan J.C Mercier wrote:
Just a quick note, it seems that the expression below (PTLIB_MINOR <= 10) will always yield a least PTLIB_VER for the most part.
for instance, if PTLIB_MAJOR =2, PTLIB_MINOR=10, it goes to the first #if, resulting in PTLIB_VER = 300 instead of 2100. Just curious to know if this is intentional.
#if PTLIB_MAJOR == 2 && PTLIB_MINOR <= 10 #define PTLIB_VER ( PTLIB_MAJOR*100 + PTLIB_MINOR*10 + PTLIB_BUILD ) #else #define PTLIB_VER ( PTLIB_MAJOR*1000 + PTLIB_MINOR*10 + PTLIB_BUILD ) #endif
Thanks
Josh
-- Jan Willamowius, jan@willamowius.de, http://www.gnugk.org/